Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpexs: rename to jpexs-ffdec #100165

wants to merge 1 commit into from


Copy link

@samuelgrf samuelgrf commented Oct 10, 2020

Motivation for this change

jpexs is just the developer's name.
The ffdec abbreviation is used in the official repo, so jpexs-ffdec seems like the best package name to use in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@@ -1,7 +1,7 @@
{ stdenv, fetchzip, makeWrapper, makeDesktopItem, jdk8 }:

stdenv.mkDerivation rec {
pname = "jpexs";
pname = "jpexs-ffdec";
Copy link

@SuperSandro2000 SuperSandro2000 Nov 27, 2020

Why not ffdec?

and please add an alias that throws an error with the new package name.

Copy link
Member Author

@samuelgrf samuelgrf commented Mar 29, 2021

Closing because I am not using the package anymore.

@samuelgrf samuelgrf closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants