Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.perfplot: 0.5.0 -> 0.8.4, fix build by packaging new dependencies #100168

merged 3 commits into from Oct 12, 2020


Copy link

@risicle risicle commented Oct 10, 2020

Motivation for this change

ZHF: #97479

Add new python packages dufte and rich to satisfy perfplot 0.8.4's dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@risicle risicle force-pushed the ris-perfplot-0.8.4 branch from 5bec524 to 50d4da3 Oct 11, 2020
Copy link

@drewrisinger drewrisinger left a comment

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review on linux-86_64:
6 packages built:
python37Packages.dufte python37Packages.perfplot python38Packages.dufte python38Packages.perfplot

@risicle risicle merged commit afee72c into NixOS:master Oct 12, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants