Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] partimage: fix build #100170

Merged
merged 1 commit into from Oct 11, 2020
Merged

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 10, 2020

Motivation for this change

ZHF: #97479

Backport of #99052

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
the move to glibc 2.30 broke the build of this old package, fortunately
debian have a patch to fix it

(cherry picked from commit 5983c41)
@risicle risicle changed the title partimage: fix build [20.09] partimage: fix build Oct 10, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 11, 2020

wow, this package is fantastically unmaintained. I think it should be considered for removal.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100170 1

1 package built:
  • partimage

@jonringer jonringer merged commit 460db36 into NixOS:release-20.09 Oct 11, 2020
18 checks passed
18 checks passed
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa25e1b"; rev="fa25e1b2941428c13ae7a87198caa409f432fce2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa25e1b"; rev="fa25e1b2941428c13ae7a87198caa409f432fce2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa25e1b"; rev="fa25e1b2941428c13ae7a87198caa409f432fce2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa25e1b"; rev="fa25e1b2941428c13ae7a87198caa409f432fce2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa25e1b"; rev="fa25e1b2941428c13ae7a87198caa409f432fce2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa25e1b"; rev="fa25e1b2941428c13ae7a87198caa409f432fce2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa25e1b"; rev="fa25e1b2941428c13ae7a87198caa409f432fce2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
partimage, partimage.passthru.tests on aarch64-linux Success
Details
partimage, partimage.passthru.tests on x86_64-linux Success
Details
@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 11, 2020

Perhaps, but it's extremely useful and can be a complete life saver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.