Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scylladb: 3.0.5 -> 4.1.8 #100178

Draft
wants to merge 1 commit into
base: master
from
Draft

scylladb: 3.0.5 -> 4.1.8 #100178

wants to merge 1 commit into from

Conversation

@volth
Copy link
Contributor

@volth volth commented Oct 10, 2020

update
Fixes #70825

@volth volth force-pushed the volth:scylla4 branch from 0ec15c5 to e0f8cd0 Oct 11, 2020
@ofborg ofborg bot requested a review from workflow Oct 11, 2020
Copy link
Contributor

@workflow workflow left a comment

This is wonderful, includes a lot of necessary and nice cleanups and makes the final build output a lot smaller as well 😅 : It went from ~18G to 80M

@volth Would you want to add yourself to the maintainers list? You seem to know a lot more about C++ builds than I do :), plus I'm not actively using scylladb anymore unfortunately.

Thank you!

Resolves #70825

meta = with stdenv.lib; {
description = "NoSQL data store using the seastar framework, compatible with Apache Cassandra";
homepage = "https://scylladb.com";
license = licenses.agpl3;
platforms = stdenv.lib.platforms.linux;
hydraPlatforms = []; # It's huge ATM, about 18 GB.

This comment has been minimized.

@workflow

workflow Oct 14, 2020
Contributor

This build is still using a fair amount of RAM, let's see how it fares on hydra or whether it needs big-parallel

This comment has been minimized.

@volth

volth Oct 14, 2020
Author Contributor

Actually, 2/3 of the build is building test programs which we drop anyway.
There could be a way to speed up the build by excluding them.

whether it needs big-parallel

Probably, not.
chromium and libreoffice do require big-parallel, but smaller packages (which nonetheless are bigger than scylla, I mean kernel, qemu, virtualbox, openjdk, clickhouse, ...) do not

install -D -m555 -t $out/bin/scylla build/release/scylla
install -D -m555 -t $out/bin/iotune build/release/iotune
Comment on lines +115 to +116

This comment has been minimized.

@workflow

workflow Oct 14, 2020
Contributor

Both scylla and iotune are single binaries, do they need their own directories?

@volth
Copy link
Contributor Author

@volth volth commented Oct 14, 2020

It went from ~18G to 80M

18G is result of keeping all the sources and temporary files (such as .o)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.