Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-exts/ms-dotnettools-csharp: Init at 1.23.2 #100181

wants to merge 1 commit into
base: master


Copy link

@jraygauthier jraygauthier commented Oct 10, 2020

Motivation for this change

Missing vscode extension. Not possible to install simply using vscode-utils.extensionsFromVscodeMarketplace as this depends on dowloaded binaries that needs to be patched.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits

Tested in isolation using the following expressions:

$ cd ~/nixpkgs_latest
$ nix-shell -I nixpkgs=. -p 'with import <nixpkgs> {config={allowUnfree = true;};}; vscode-with-extensions.override {vscodeExtensions = with vscode-extensions; [ms-dotnettools.csharp];}'
$ nix-build -I nixpkgs=. -E 'with import <nixpkgs> {config={allowUnfree = true;};}; vscode-with-extensions.override {vscodeExtensions = with vscode-extensions; [ms-dotnettools.csharp];}'
@jraygauthier jraygauthier force-pushed the jraygauthier:jrg/ms-dotnettools-csharp branch from 637bfe7 to f343ec2 Oct 21, 2020
Copy link
Member Author

@jraygauthier jraygauthier commented Oct 21, 2020

This latest version add a patch that fixes debugging a specific test.

At this point, this extension as been quite extensively tested on projects of significant size. It works impressively well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.