Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-play-music-desktop-player: copy icons #100186



Copy link

@AlexGoico AlexGoico commented Oct 10, 2020

Icons need to be copied over to correct directories in order for share's .desktop to function.

Motivation for this change

Issue: #98139
Unable to get Google play music to launch from KDE without a terminal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
AlexGoico added 2 commits Oct 10, 2020
Icons need to be copied over to correct directories in order for
share's .desktop to function.
Add imagemagick for convert in previous commit
Copy link

@SuprDewd SuprDewd left a comment


Copy link

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100186 run on x86_64-linux 1

1 package built:
  • google-play-music-desktop-player

Copy link

@SuperSandro2000 SuperSandro2000 left a comment

Please squash the commits.

Copy link

@dotlambda dotlambda commented Mar 6, 2021

Closing this as Google Play Music was discontinued.

@dotlambda dotlambda closed this Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants