Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yle-dl: 2.31 -> 20200807 #100191

Merged
merged 4 commits into from Oct 28, 2020
Merged

yle-dl: 2.31 -> 20200807 #100191

merged 4 commits into from Oct 28, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 11, 2020

Motivation for this change

https://r.ryantm.com/log/2020-10-09.log

Things done

Updated to latest version and fixed tests when enabled.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sikmir
Copy link
Member

@sikmir sikmir commented Oct 12, 2020

@SuperSandro2000 Please, update license to licenses.gpl3Plus, since licenses.gpl3 is deprecated (https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206/4).
See https://github.com/aajanki/yle-dl/blob/3100fa5f4f82583d092e580930b84cd3214860f1/setup.py#L56:
'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',

@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:yle-dl branch from 347a713 to 7cb7ad4 Oct 13, 2020
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 13, 2020

@SuperSandro2000 Please, update license to licenses.gpl3Plus, since licenses.gpl3 is deprecated (discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206/4).
See aajanki/yle-dl@3100fa5/setup.py#L56:
'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',

@sikmir Changed that. Thanks for the notice.

@sikmir
Copy link
Member

@sikmir sikmir commented Oct 27, 2020

20201022 is out.

@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:yle-dl branch from 7cb7ad4 to b12d57a Oct 27, 2020
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 27, 2020

20201022 is out.

Updated. Thanks for the notice!

pkgs/tools/misc/yle-dl/default.nix Outdated Show resolved Hide resolved
Thanks @sikmir

Co-authored-by: Nikolay Korotkiy <sikmir@gmail.com>
@sikmir
sikmir approved these changes Oct 27, 2020
@sikmir
Copy link
Member

@sikmir sikmir commented Oct 28, 2020

yle-dl moved to python3 #101964

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 28, 2020

I was wondering why this looked so familiar #67656

Copy link
Contributor

@jonringer jonringer left a comment

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/100191
1 package built:
yle-dl
@jonringer jonringer merged commit 99bf27c into NixOS:master Oct 28, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="100ddc3"; rev="100ddc3fe7c2b9cf9dd8c19c23d51c4c1e193bd3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="100ddc3"; rev="100ddc3fe7c2b9cf9dd8c19c23d51c4c1e193bd3"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="100ddc3"; rev="100ddc3fe7c2b9cf9dd8c19c23d51c4c1e193bd3"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="100ddc3"; rev="100ddc3fe7c2b9cf9dd8c19c23d51c4c1e193bd3"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="100ddc3"; rev="100ddc3fe7c2b9cf9dd8c19c23d51c4c1e193bd3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="100ddc3"; rev="100ddc3fe7c2b9cf9dd8c19c23d51c4c1e193bd3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="100ddc3"; rev="100ddc3fe7c2b9cf9dd8c19c23d51c4c1e193bd3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
yle-dl, yle-dl.passthru.tests on aarch64-linux Success
Details
@ofborg
yle-dl, yle-dl.passthru.tests on x86_64-linux Success
Details
@SuperSandro2000 SuperSandro2000 deleted the SuperSandro2000:yle-dl branch Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants