Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ats2: 0.3.13 -> 0.4.1 #100196

Merged
merged 1 commit into from Oct 11, 2020
Merged

ats2: 0.3.13 -> 0.4.1 #100196

merged 1 commit into from Oct 11, 2020

Conversation

@thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Oct 11, 2020

Motivation for this change

I have another PR updating ATS2 to 0.4.0 since January ( #78551 ), but another version was released in the meantime. =)

Things done

I've compiled a simple Hello World program with the current 0.4.1 version.

Closure size comparison:

/nix/store/j6wfc97p0p19g1wgd1f6d56q0g792alp-ats2-0.3.13	   50863880 
/nix/store/waabcfccjfqdpfvfb7lki5whvrnxndki-ats2-0.4.1	   45984152
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@marsam marsam merged commit d7eafce into NixOS:master Oct 11, 2020
19 checks passed
@marsam marsam mentioned this pull request Oct 11, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants