Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sndio: use multiple outputs #100197

Closed
wants to merge 1 commit into from
Closed

sndio: use multiple outputs #100197

wants to merge 1 commit into from

Conversation

@S-NA
Copy link
Contributor

@S-NA S-NA commented Oct 11, 2020

Motivation for this change

Use multiple outputs, reduce runtime closure size, etc..

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I built mpv as well.

Also add myself as a maintainer.
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 12, 2020

But sndio is only 460Kb. multiple outputs can cause issues1, and in this case I'm afraid it doesn't worth the risk / benefit.

1: Consider for instance:

$ git grep 'fix_pkgconfig_includedir\.patch' pkgs/development/libraries/gstreamer/

Though there it's a different build system, but still. See discussion: https://discourse.nixos.org/t/could-weve-implemented-multi-output-packages-better/6597/

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Closing cause the advantage is really small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants