Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hime: fix enable hime, remove hime-all package #100213

Merged
merged 1 commit into from Oct 17, 2020
Merged

hime: fix enable hime, remove hime-all package #100213

merged 1 commit into from Oct 17, 2020

Conversation

@yanganto
Copy link
Member

@yanganto yanganto commented Oct 11, 2020

Motivation for this change
  • fix inputMethod.enable hime
  • rm hime-all package, because chewing, anthy modules does not work well
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@yanganto
Copy link
Member Author

@yanganto yanganto commented Oct 16, 2020

Hi @marsam,

I need your help to hotfix this package.

Sorry about putting a package with a bug, this bug is fixed and I have used some input methods with this package about one week.
Besides, some input methods do not work fine, so I disable it.

ref: #98163

@marsam
Copy link
Contributor

@marsam marsam commented Oct 17, 2020

Sorry about putting a package with a bug, this bug is fixed and I have used some input methods with this package about one week.

please don't worry about it. we are all human, it's okay to make mistakes :)

- fix inputMethod.enable hime by adding module list
- rm hime-all package, because chewing, anthy modules does not work well
@marsam marsam merged commit 2a58362 into NixOS:master Oct 17, 2020
19 checks passed
@yanganto yanganto deleted the hotfix-hime branch May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants