Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hime: fix enable hime, remove hime-all package #100213

Merged
merged 1 commit into from Oct 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions nixos/modules/i18n/input-method/default.xml
Expand Up @@ -252,8 +252,8 @@ i18n.inputMethod = {
<para>
Hime is an extremely easy-to-use input method framework. It is lightweight,
stable, powerful and supports many commonly used input methods, including
Cangjie, Zhuyin, Dayi, Rank, Shrimp, Greek, Japanese Anthy, Korean Pinyin,
Latin Alphabet, Rancang hunting birds, cool music, etc...
Cangjie, Zhuyin, Dayi, Rank, Shrimp, Greek, Korean Pinyin, Latin Alphabet,
etc...
</para>

<para>
Expand Down
18 changes: 2 additions & 16 deletions nixos/modules/i18n/input-method/hime.nix
@@ -1,23 +1,9 @@
{ config, pkgs, ... }:
{ config, pkgs, lib, ... }:

with lib;
{
options = {
i18n.inputMethod.hime = {
enableChewing = mkOption {
type = with types; nullOr bool;
default = null;
description = "enable chewing input method";
};
enableAnthy = mkOption {
type = with types; nullOr bool;
default = null;
description = "enable anthy input method";
};
};
};

config = mkIf (config.i18n.inputMethod.enabled == "hime") {
i18n.inputMethod.package = pkgs.hime;
environment.variables = {
GTK_IM_MODULE = "hime";
QT_IM_MODULE = "hime";
Expand Down
1 change: 1 addition & 0 deletions nixos/modules/module-list.nix
Expand Up @@ -79,6 +79,7 @@
./hardware/xpadneo.nix
./i18n/input-method/default.nix
./i18n/input-method/fcitx.nix
./i18n/input-method/hime.nix
./i18n/input-method/ibus.nix
./i18n/input-method/nabi.nix
./i18n/input-method/uim.nix
Expand Down
28 changes: 11 additions & 17 deletions pkgs/tools/inputmethods/hime/default.nix
@@ -1,9 +1,10 @@
{
stdenv, fetchFromGitHub, pkgconfig, which, gtk2, gtk3, qt4, qt5, libXtst, lib,
enableChewing ? true, libchewing,
enableAnthy ? true, anthy,
}:

# chewing and anthy do not work well
# so we do not enable these input method at this moment

stdenv.mkDerivation {
name = "hime";
version = "unstable-2020-06-27";
Expand All @@ -16,25 +17,18 @@ stdenv.mkDerivation {
};

nativeBuildInputs = [ which pkgconfig ];
buildInputs = [ libXtst gtk2 gtk3 qt4 qt5.qtbase ]
++ lib.optional enableChewing libchewing
++ lib.optional enableAnthy anthy;

patchPhase = ''
patchShebangs configure
'';
buildInputs = [ libXtst gtk2 gtk3 qt4 qt5.qtbase ];

# The configure script already auto-detect libchewing and anthy,
# so we do not need additional flags for libchewing or anthy
preConfigure = "patchShebangs configure";
configureFlags = [ "--disable-lib64" "--disable-qt5-immodule" ];


meta = with stdenv.lib; {
homepage = "http://hime-ime.github.io/";
downloadPage = "https://github.com/hime-ime/hime/downloads";
description = "A useful input method engine for Asia region";
license = licenses.gpl2Plus;
platforms = platforms.linux;
maintainers = with maintainers; [ yanganto ];
homepage = "http://hime-ime.github.io/";
downloadPage = "https://github.com/hime-ime/hime/downloads";
description = "A useful input method engine for Asia region";
license = licenses.gpl2Plus;
platforms = platforms.linux;
maintainers = with maintainers; [ yanganto ];
};
}
9 changes: 2 additions & 7 deletions pkgs/top-level/all-packages.nix
Expand Up @@ -1104,6 +1104,8 @@ in

google-amber = callPackage ../tools/graphics/amber { };

hime = callPackage ../tools/inputmethods/hime {};

hpe-ltfs = callPackage ../tools/backup/hpe-ltfs { };

http2tcp = callPackage ../tools/networking/http2tcp { };
Expand Down Expand Up @@ -5595,13 +5597,6 @@ in

nabi = callPackage ../tools/inputmethods/nabi { };

hime = callPackage ../tools/inputmethods/hime {};

hime-all = callPackage ../tools/inputmethods/hime {
enableChewing = true;
enableAnthy = true;
};

nahid-fonts = callPackage ../data/fonts/nahid-fonts { };

namazu = callPackage ../tools/text/namazu { };
Expand Down