Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stretchly: 0.21.1 -> 1.2.0 #100214

Merged
merged 1 commit into from Oct 13, 2020
Merged

stretchly: 0.21.1 -> 1.2.0 #100214

merged 1 commit into from Oct 13, 2020

Conversation

@1000101
Copy link
Member

@1000101 1000101 commented Oct 11, 2020

Motivation for this change

Update stretchly, with additional housekeeping (remove wrapGAppsHook). Newer versions switched to electron 9 (fixes errors seen in #93530) and the update script was missing a dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@1000101
Copy link
Member Author

@1000101 1000101 commented Oct 11, 2020

@GrahamcOfBorg build stretchly

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Oct 11, 2020

@1000101 I don't actually use stretchly anymore, would you like to take over maintainership for this?

@1000101
Copy link
Member Author

@1000101 1000101 commented Oct 11, 2020

@1000101 I don't actually use stretchly anymore, would you like to take over maintainership for this?

Sure, I'd be happy to.

Would you mind checking if it works properly? I'm not using any tray/notif extension in GNOME so it's not showing up, but it seems to work fine. Works fine in KDE. Although a desktop shortcut might be handy anyway.

@1000101
Copy link
Member Author

@1000101 1000101 commented Oct 11, 2020

@GrahamcOfBorg build stretchly

@1000101
Copy link
Member Author

@1000101 1000101 commented Oct 11, 2020

@1000101 I don't actually use stretchly anymore, would you like to take over maintainership for this?

Ok, I've changed maintainer to myself and added desktop/icon support so it's possible to launch the app outside of Terminal.

Copy link
Member

@cdepillabout cdepillabout left a comment

This appears to work. The system tray icon appears to show up correct.

@1000101 Thanks for taking this over!

@cdepillabout cdepillabout merged commit 4f1c500 into NixOS:master Oct 13, 2020
20 of 23 checks passed
@1000101 1000101 deleted the stretchly branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants