Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-bindgen: 0.54.1 -> 0.55.1 #100229

Merged
merged 1 commit into from Oct 20, 2020
Merged

Conversation

@JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Oct 11, 2020

Motivation for this change

Updates rust-bindgen to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100229 1

1 package built:
  • rust-bindgen

@JohnTitor
Copy link
Member Author

@JohnTitor JohnTitor commented Oct 20, 2020

@jonringer Thanks for confirming! Seems @Ralith is busy, could you merge this if it's okay?

@jonringer jonringer merged commit afc8027 into NixOS:master Oct 20, 2020
19 checks passed
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 20, 2020

pretty sure i meant to, just didn't get back to it for some reason

@JohnTitor
Copy link
Member Author

@JohnTitor JohnTitor commented Oct 20, 2020

I see, thanks anyway!

@JohnTitor JohnTitor deleted the rust-bindgen-0.55.1 branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants