Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdeApplications.print-manager: add qtquickcontrols2 #100236

Closed
wants to merge 1 commit into from

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 11, 2020

Motivation for this change

Fixes #98536

Things done

I enabled printing in QEMU NixOS VM. systemsettings printing all opened, but I didn't see the plasmoid anywhere.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@samuelgrf
Copy link
Member

@samuelgrf samuelgrf commented Oct 11, 2020

This doesn't fix the issue for me, the plasmoid still shows the same error message; the menu in systemsettings already worked fine previously.

@ttuegel
Copy link
Member

@ttuegel ttuegel commented Oct 12, 2020

This won't fix the issue because it's a problem at runtime. It's also not appropriate because print-manager doesn't have a direct dependency on qtquickcontrols2. The dependency is through plasma-framework; the problem lies there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants