Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devilutionx: 1.0.1 -> 1.1.0-nixpkg-static-sdl2 #100238

Closed

Conversation

@karolchmist
Copy link
Contributor

@karolchmist karolchmist commented Oct 11, 2020

Motivation for this change

The build of devilutoinX was broken on master due to changes in SDL2 build.

Also, a new version 1.1.0 of DevilutionX was released unexpectedly.

This PR proposes a build based on a fork of devilutionX, until the upstream enables building with static SDL2. Hopefully it will be included NixOS 20.09 (though I'm affraid it's too late probably).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@karolchmist
Copy link
Contributor Author

@karolchmist karolchmist commented Oct 14, 2020

Closing for now as dynamic linking is preferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant