Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pystemd: 0.6.0 -> 0.8.0 #100263

merged 1 commit into from Oct 11, 2020

pystemd: 0.6.0 -> 0.8.0 #100263

merged 1 commit into from Oct 11, 2020


Copy link

@p-h p-h commented Oct 11, 2020

This is my first PR. Let me know if I made a mistake.

ZHF: #97479

Motivation for this change
  • pystemd is outdated
  • 0.6 doesn't work on python3.8+
Things done
  • updated to new package version
  • set minimum python version to 3.4
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@flokli flokli commented Oct 11, 2020

Result of nixpkgs-review pr 100263 1

2 packages built:
- python37Packages.pystemd
- python38Packages.pystemd

Copy link

@flokli flokli commented Oct 11, 2020

Also verified things work with Python 3.8:

❯ nix-shell -I nixpkgs=$PWD -p python38 python38.pkgs.pystemd

[nix-shell:~/dev/nixos/nixpkgs-20.09]$ python
Python 3.8.5 (default, Jul 20 2020, 13:26:22) 
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pystemd.systemd1 import Unit
>>> unit = Unit(b'display-manager.service')
>>> unit.load()
>>> unit.Unit.ActiveState


@flokli flokli merged commit 74c4056 into NixOS:master Oct 11, 2020
13 of 16 checks passed
@p-h p-h deleted the pystemd-0.8.0 branch Oct 11, 2020
@p-h p-h mentioned this pull request Oct 11, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants