Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cagebreak: 1.4.2 -> 1.4.3 #100271

Merged
merged 2 commits into from Oct 13, 2020
Merged

cagebreak: 1.4.2 -> 1.4.3 #100271

merged 2 commits into from Oct 13, 2020

Conversation

@berbiche
Copy link
Member

@berbiche berbiche commented Oct 11, 2020

Motivation for this change

Fixes

  • Issue 17
    Cagebreak up to and including version 1.4.2 might have a use-after-free on destroying unmapped views. view->workspace was set on view creation. If the output containing this view was subsequently destroyed, the workspace was freed, leading to a use-after-free when the view was destroyed.
  • Issue 18
    Cagebreak up to and including release 1.4.2 does not handle the position of xwayland views adequately.
  • Issue 19
    Cagebreak up to and including release 1.4.2 does not handle unmanaged views adequately.
  • Issue 20
    Cagebreak up to and including release 1.4.2 does not handle damaging adequately, when scanning out views.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 12, 2020

@berbiche berbiche force-pushed the cagebreak-1.4.3 branch from 88cd217 to 3b7c430 Oct 12, 2020
@berbiche
Copy link
Member Author

@berbiche berbiche commented Oct 12, 2020

The tests have passed successfully 8 out of 8 runs on my system.

@berbiche
Copy link
Member Author

@berbiche berbiche commented Oct 13, 2020

I updated the Wayland test-case to use wayinfo from Wallutils

@berbiche berbiche force-pushed the cagebreak-1.4.3 branch from 3b7c430 to b1296f4 Oct 13, 2020
@doronbehar doronbehar merged commit a17c7a9 into NixOS:master Oct 13, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants