Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.proto-plus: run tests #100275

Closed
wants to merge 1 commit into from
Closed

Conversation

@ruuda
Copy link
Contributor

@ruuda ruuda commented Oct 11, 2020

Motivation for this change

This is a follow-up to #100138 (comment). As @risicle pointed out, the tests were not actually being run. This pull request implements the proposed fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
As risicle pointed out, the tests were not being run previously, because
they failed to discover any tests. Add the Pytest hook to fix this. This
also reveals that the package needs Python 3.
@ruuda ruuda requested review from FRidh and jonringer as code owners Oct 11, 2020
@ruuda
Copy link
Contributor Author

@ruuda ruuda commented Oct 11, 2020

Never mind, I missed #100223.

@risicle
Copy link
Contributor

@risicle risicle commented Oct 12, 2020

Great minds...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants