Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.recents: init at 2019-11-29 #100278

Closed
wants to merge 1 commit into from
Closed

Conversation

@dawidsowa
Copy link
Contributor

@dawidsowa dawidsowa commented Oct 11, 2020

Motivation for this change

Add Recents gnome extension.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 11, 2020

Did you check if the extension works?

Also it looks like it will not work with GNOME 3.38, which we are going to merge in near future.

@dawidsowa
Copy link
Contributor Author

@dawidsowa dawidsowa commented Oct 11, 2020

Yes, it works.

As for 3.38, I'll convert PR to draft and wait till it's fixed.

@dawidsowa dawidsowa marked this pull request as draft Oct 11, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100278 run on x86_64-linux 1

1 package built:
  • gnomeExtensions.recents

@stale
Copy link

@stale stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale label Jun 3, 2021
@dawidsowa dawidsowa closed this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants