Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery-dl: 1.15.0 -> 1.15.1 #100280

Merged
merged 1 commit into from Oct 12, 2020
Merged

gallery-dl: 1.15.0 -> 1.15.1 #100280

merged 1 commit into from Oct 12, 2020

Conversation

@dawidsowa
Copy link
Contributor

@dawidsowa dawidsowa commented Oct 11, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 12, 2020

Result of nixpkgs-review pr 100280 1

1 package built:
  • gallery-dl

Copy link
Member

@mweinelt mweinelt left a comment

LGTM.

Can you please see if you can get the tests up and running? Looks like pytestCheckHook could work.

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 12, 2020

diff --git a/pkgs/applications/misc/gallery-dl/default.nix b/pkgs/applications/misc/gallery-dl/default.nix
index db82aea2a50..b88b6a8ae9b 100644
--- a/pkgs/applications/misc/gallery-dl/default.nix
+++ b/pkgs/applications/misc/gallery-dl/default.nix
@@ -9,9 +9,14 @@ python3Packages.buildPythonApplication rec {
     sha256 = "1g9hmb5637x8bhm2wzarqnxzj0i93fcdm1myvld2d97a2d32hy6m";
   };
 
-  doCheck = false;
   propagatedBuildInputs = with python3Packages; [ requests ];
 
+  checkInputs = with python3Packages; [ pytestCheckHook ];
+  pytestFlagsArray = [
+    # requires network access
+    "--ignore=test/test_results.py"
+  ];
+
   meta = {
     description = "Command-line program to download image-galleries and -collections from several image hosting sites";
     homepage = "https://github.com/mikf/gallery-dl";

@dawidsowa dawidsowa changed the title gallery-dl: 1.5.0 -> 1.5.1 gallery-dl: 1.15.0 -> 1.15.1 Oct 12, 2020
@dawidsowa
Copy link
Contributor Author

@dawidsowa dawidsowa commented Oct 12, 2020

Yes, it works now

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 12, 2020

Result of nixpkgs-review pr 100280 1

1 package built:
  • gallery-dl

@mweinelt mweinelt merged commit 3894b89 into NixOS:master Oct 12, 2020
19 checks passed
@dawidsowa dawidsowa deleted the gallery-dl branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants