Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.scrapy: 2.3.0 -> 2.4.0 #100283

Merged
merged 1 commit into from Oct 12, 2020
Merged

pythonPackages.scrapy: 2.3.0 -> 2.4.0 #100283

merged 1 commit into from Oct 12, 2020

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Oct 11, 2020

Motivation for this change

https://github.com/scrapy/scrapy/releases/tag/2.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@marsam
Copy link
Contributor Author

@marsam marsam commented Oct 12, 2020

@GrahamcOfBorg build python3Packages.scrapy

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100283 1

8 packages failed to build:
  • python37Packages.scrapy
  • python37Packages.scrapy-deltafetch
  • python37Packages.scrapy-fake-useragent
  • python37Packages.scrapy-splash
  • python38Packages.scrapy
  • python38Packages.scrapy-deltafetch
  • python38Packages.scrapy-fake-useragent
  • python38Packages.scrapy-splash

@jonringer jonringer merged commit 8c154d0 into NixOS:master Oct 12, 2020
17 checks passed
17 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84c3e0a"; rev="84c3e0abf4c819132e41ea1b58dce986924c7e2c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84c3e0a"; rev="84c3e0abf4c819132e41ea1b58dce986924c7e2c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84c3e0a"; rev="84c3e0abf4c819132e41ea1b58dce986924c7e2c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84c3e0a"; rev="84c3e0abf4c819132e41ea1b58dce986924c7e2c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84c3e0a"; rev="84c3e0abf4c819132e41ea1b58dce986924c7e2c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84c3e0a"; rev="84c3e0abf4c819132e41ea1b58dce986924c7e2c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="84c3e0a"; rev="84c3e0abf4c819132e41ea1b58dce986924c7e2c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants