Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sozu: 0.11.46 -> 0.11.50; fix Darwin build #100290

Merged
merged 1 commit into from Nov 2, 2020
Merged

Conversation

@happysalada
Copy link
Contributor

@happysalada happysalada commented Oct 12, 2020

Motivation for this change

build was broken on darwin

Things done
  • I ran nixfmt, so formatting has changed a bit
  • As opposed to the last similar PR, I didn't alias Security from apple_sdk, so this PR should pass the build
  • upgraded sozu from 0.11.46 -> 0.11.50
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@happysalada
Copy link
Contributor Author

@happysalada happysalada commented Oct 12, 2020

@Br1ght0ne Last PR had an alias that wasn't propagated to all-packages.nix, this one should pass.

pkgs/servers/sozu/default.nix Outdated Show resolved Hide resolved
pkgs/servers/sozu/default.nix Outdated Show resolved Hide resolved
@happysalada happysalada requested a review from sikmir Oct 14, 2020
pkgs/servers/sozu/default.nix Outdated Show resolved Hide resolved
sikmir
sikmir approved these changes Oct 14, 2020
@happysalada happysalada requested a review from sikmir Oct 14, 2020
sikmir
sikmir approved these changes Oct 14, 2020
@happysalada happysalada requested a review from sikmir Oct 23, 2020
@happysalada
Copy link
Contributor Author

@happysalada happysalada commented Oct 23, 2020

@sikmir not sure, who to ask to get this merged

sikmir
sikmir approved these changes Oct 23, 2020
@sikmir sikmir requested a review from Br1ght0ne Oct 23, 2020
@happysalada
Copy link
Contributor Author

@happysalada happysalada commented Nov 1, 2020

@danieldk When you have a moment.

Copy link
Member

@danieldk danieldk left a comment

Commit messages must follow the format in CONTRIBUTING.md. Though, in this case it's probably enough to squash the commits in a single commit with the message

sozu: 0.11.46 -> 0.11.50; fix Darwin build

@happysalada
Copy link
Contributor Author

@happysalada happysalada commented Nov 1, 2020

@danieldk Thanks for having a look at it so quickly!

Copy link
Member

@danieldk danieldk left a comment

Result of nixpkgs-review pr 100290 1

1 package built:
  • sozu

@danieldk danieldk merged commit b31e052 into NixOS:master Nov 2, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants