Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ugtrain: init at v0.4.1 #100333

Merged
merged 1 commit into from Nov 27, 2020
Merged

ugtrain: init at v0.4.1 #100333

merged 1 commit into from Nov 27, 2020

Conversation

@mtrsk
Copy link
Member

@mtrsk mtrsk commented Oct 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mtrsk mtrsk force-pushed the mtrsk:add-ugtrain branch 2 times, most recently from 9bc7eb6 to abfe3e8 Oct 12, 2020
pkgs/tools/misc/ugtrain/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/ugtrain/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/ugtrain/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/ugtrain/default.nix Outdated Show resolved Hide resolved
@mtrsk mtrsk force-pushed the mtrsk:add-ugtrain branch from abfe3e8 to 8657ed5 Oct 12, 2020
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 12, 2020

Result of nixpkgs-review pr 100333 1

1 package built:
  • ugtrain

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 12, 2020

Passes nixpkgs-review build and --help test.

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 12, 2020

pkg-config belongs in nativeBuildInputs.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 12, 2020

pkg-config belongs in nativeBuildInputs.

Good catch.

@mtrsk
Copy link
Member Author

@mtrsk mtrsk commented Oct 12, 2020

pkg-config belongs in nativeBuildInputs.

I get some build errors when removing pkg-config from buildInputs.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 13, 2020

I get some build errors when removing pkg-config from buildInputs.

You should put it in nativeBuildInputs instead:

diff --git i/pkgs/tools/misc/ugtrain/default.nix w/pkgs/tools/misc/ugtrain/default.nix
index 90504ead77b..0645645ae2b 100644
--- i/pkgs/tools/misc/ugtrain/default.nix
+++ w/pkgs/tools/misc/ugtrain/default.nix
@@ -16,8 +16,7 @@ stdenv.mkDerivation rec {
     sha256 = "0pw9lm8y83mda7x39874ax2147818h1wcibi83pd2x4rp1hjbkkn";
   };
 
-  nativeBuildInputs = [ autoreconfHook scanmem ];
-  buildInputs = [ pkg-config ];
+  nativeBuildInputs = [ autoreconfHook pkg-config scanmem ];
 
   meta = with stdenv.lib; {
     homepage = "https://github.com/ugtrain/ugtrain";

@mtrsk mtrsk force-pushed the mtrsk:add-ugtrain branch from 8657ed5 to 9de5bf4 Oct 13, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100333 run on x86_64-linux 1

1 package built:
  • ugtrain

@SuperSandro2000 SuperSandro2000 merged commit 20473a2 into NixOS:master Nov 27, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9de5bf4"; rev="9de5bf446a55936dfd8b2abbfd38eadff6aa0aed"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9de5bf4"; rev="9de5bf446a55936dfd8b2abbfd38eadff6aa0aed"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9de5bf4"; rev="9de5bf446a55936dfd8b2abbfd38eadff6aa0aed"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9de5bf4"; rev="9de5bf446a55936dfd8b2abbfd38eadff6aa0aed"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9de5bf4"; rev="9de5bf446a55936dfd8b2abbfd38eadff6aa0aed"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9de5bf4"; rev="9de5bf446a55936dfd8b2abbfd38eadff6aa0aed"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9de5bf4"; rev="9de5bf446a55936dfd8b2abbfd38eadff6aa0aed"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
ugtrain, ugtrain.passthru.tests on aarch64-linux Success
Details
@ofborg
ugtrain, ugtrain.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants