Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit: init at 0.5.11 #100340

Closed
wants to merge 1 commit into from
Closed

bit: init at 0.5.11 #100340

wants to merge 1 commit into from

Conversation

@rople380
Copy link
Contributor

@rople380 rople380 commented Oct 12, 2020

Motivation for this change

bit: init at 0.5.11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
sha256 = "1rdi6wsr5w64gvqkdysxrxfjxi3xbwigy3sk8wsx9zp4fql9xnw1";
};

subPackages = [ "." ];

This comment has been minimized.

@doronbehar

doronbehar Oct 12, 2020
Contributor

Necessary?

This comment has been minimized.

@rople380

rople380 Oct 13, 2020
Author Contributor

Maybe not, pulled from another example, squashes a branch testing bug.


vendorSha256 = "16c1mcvz3z17pixp904hazivx2n7y592nlx3ndnyajk7ljmnwfzy";

meta = with lib; {

This comment has been minimized.

This comment has been minimized.

@rople380

rople380 Oct 13, 2020
Author Contributor

Just adding to buildInputs should suffice?

This comment has been minimized.

@doronbehar

doronbehar Oct 13, 2020
Contributor

No. that won't affect it at all. Use something like this:

postFixup = ''
for bin in $out/bin/*; do
wrapProgram $bin \
--prefix PATH : "${wrapperPath}"
done
'';

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

@rople380 please address the reviewer comments.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft Nov 27, 2020
@stale
Copy link

@stale stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale label Jun 3, 2021
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jun 4, 2021

Closing as OP doesn't respond.

@doronbehar doronbehar closed this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants