Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: move extension derivations to separate dirs #100341

Merged
merged 25 commits into from Oct 14, 2020

Conversation

@etu
Copy link
Contributor

@etu etu commented Oct 12, 2020

Motivation for this change

More cleaning up, also adding the new folder to the codeowners for the team

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
etu added 25 commits Oct 11, 2020
These variables have bad names that doesn't really make full sense
@etu etu requested a review from Oct 12, 2020
@etu etu requested a review from edolstra as a code owner Oct 12, 2020
@ofborg ofborg bot requested review from aanderse and globin Oct 12, 2020
@ofborg ofborg bot requested review from Ma27 and talyz Oct 12, 2020
@etu etu merged commit 90a7b76 into NixOS:master Oct 14, 2020
17 checks passed
@etu etu deleted the php-move-extension-derivations-to-separate-dirs branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant