Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foot: 1.4.4 -> 1.5.1 #100345

Merged
merged 3 commits into from Oct 14, 2020
Merged

foot: 1.4.4 -> 1.5.1 #100345

merged 3 commits into from Oct 14, 2020

Conversation

@SeTSeR
Copy link
Contributor

@SeTSeR SeTSeR commented Oct 12, 2020

Motivation for this change

Update foot to latest version. It also required to update some of foot's dependencies and add new dependency for fcft.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@sternenseemann sternenseemann left a comment

Totally missed foot 1.5.1 and updating #98270.

Commented some smaller clean ups you could do in this changes. Enabling tests for tllist would be good as well.

Also squash the two fcft commits into one please.

pkgs/applications/misc/foot/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/tllist/default.nix Show resolved Hide resolved
pkgs/development/libraries/tllist/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/fcft/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from sternenseemann Oct 12, 2020
SeTSeR and others added 3 commits Oct 12, 2020
Co-authored-by: sternenseemann <git@lukasepple.de>
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100345 1

4 packages built:
  • fcft
  • foot
  • fuzzel
  • tllist

@jonringer jonringer merged commit b62f286 into NixOS:master Oct 14, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants