Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt-manager: 2.2.1 -> 3.1.0 #100349

Merged
merged 1 commit into from Oct 14, 2020
Merged

virt-manager: 2.2.1 -> 3.1.0 #100349

merged 1 commit into from Oct 14, 2020

Conversation

@jul1u5
Copy link
Contributor

@jul1u5 jul1u5 commented Oct 12, 2020

Motivation for this change

Changelog: (3.1.0, 3.0.0)

Package changes
  • Add docutils, because virt-manager now uses rst2man to generate man pages. I wasn't sure if the nativeBuildInputs is the correct place for docutils, but as far as I have tested, that's the only place where the build doesn't fail.
Notes
  • virt-manager is now using pytest, so it might be easier to integrate tests. I haven't tried that though.
  • I wasn't sure about the formatting of the file, so it might be incorrect.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested review from globin, offlinehacker, qknight and fpletz Oct 12, 2020
@marsam marsam merged commit c213d5a into NixOS:master Oct 14, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants