Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghorg: init at 1.4.0 #100350

Merged
merged 1 commit into from Oct 20, 2020
Merged

ghorg: init at 1.4.0 #100350

merged 1 commit into from Oct 20, 2020

Conversation

@vidbina
Copy link
Contributor

@vidbina vidbina commented Oct 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Now, just some cosmetic changes.

@vidbina vidbina force-pushed the init-ghorg-v1.4.0 branch from 9711e2a to aded336 Oct 19, 2020
export HOME=$TMPDIR
mkdir -p $HOME/.config/ghorg
cp sample-conf.yaml $HOME/.config/ghorg/conf.yaml
'';
Copy link
Member

@AndersonTorres AndersonTorres Oct 19, 2020

Is this preBuild section still needed? If this is just for tests, it can be ignored for now.

@vidbina vidbina force-pushed the init-ghorg-v1.4.0 branch from aded336 to abb7f22 Oct 20, 2020
Copy link
Member

@AndersonTorres AndersonTorres left a comment

  • LGTM
  • LGTBorg

@AndersonTorres AndersonTorres merged commit 751d7c6 into NixOS:master Oct 20, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants