Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.{matklad.rust-analyzer,vadimcn.vscode-lldb}: fix build error #100358

Closed
wants to merge 1 commit into from

Conversation

@oxalica
Copy link
Contributor

@oxalica oxalica commented Oct 12, 2020

Motivation for this change

Workaround for #100077 to fix build errors on current master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@oxalica oxalica force-pushed the fix/node2nix-npm-error branch from fd7ec43 to f2ebead Oct 13, 2020
@ofborg ofborg bot requested a review from midchildan Oct 13, 2020
@oxalica oxalica force-pushed the fix/node2nix-npm-error branch from f2ebead to c94a0f3 Oct 14, 2020
@ofborg ofborg bot requested a review from midchildan Oct 14, 2020
@oxalica
Copy link
Contributor Author

@oxalica oxalica commented Oct 16, 2020

ping @jonringer

@oxalica
Copy link
Contributor Author

@oxalica oxalica commented Oct 20, 2020

Close for:

  • vscode-extensions.matklad.rust-analyzer is successfully built on master for no reason. 😕
  • vscode-lldb fix is included in #101179.

@oxalica oxalica closed this Oct 20, 2020
@oxalica oxalica deleted the fix/node2nix-npm-error branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants