Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.spyder_3: remove broken gui app #100366

Closed

Conversation

@marcus7070
Copy link
Member

@marcus7070 marcus7070 commented Oct 12, 2020

@FRidh, this continues from #100126.

Motivation for this change

A recent update to Qt broke the gui app. This library is only used for
cq-editor and still works fine for that purpose, so this patch just
trims the gui app stuff out of setup.py.

I've also added some pythonImportsChecks, they are the exact modules that cq-editor needs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Result of nixpkgs-review 1
3 packages built:
  • cq-editor
  • python37Packages.spyder_3
  • python38Packages.spyder_3
A recent update to Qt broke the gui app. This library is only used for
cq-editor and still works fine for that purpose, so this patch just
trims the gui app stuff out of setup.py.
@stale
Copy link

@stale stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants