Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

croc: 8.3.1 -> 8.5.0 #100368

Merged
merged 1 commit into from Oct 13, 2020
Merged

croc: 8.3.1 -> 8.5.0 #100368

merged 1 commit into from Oct 13, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 12, 2020

https://github.com/schollz/croc/releases/tag/v8.3.2
https://github.com/schollz/croc/releases/tag/v8.4.0
https://github.com/schollz/croc/releases/tag/v8.5.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@HugoReeves HugoReeves left a comment

Builds and executes on MacOS. The output of croc --verison shows croc version v8.4.0-224c44
However, this seems to be an upstream issue with version tagging and shouldn't cause any problems.
LGTM

@zowoq zowoq merged commit acd388d into NixOS:master Oct 13, 2020
19 of 20 checks passed
@zowoq zowoq deleted the croc branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants