Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R: 4.0.2 -> 4.0.3 #100393

Merged
merged 1 commit into from Oct 25, 2020
Merged

R: 4.0.2 -> 4.0.3 #100393

merged 1 commit into from Oct 25, 2020

Conversation

@matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Oct 13, 2020

Build pending on my server... Will update as soon as it succeeded.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@ofborg ofborg bot requested review from timokau and peti Oct 13, 2020
@matthiasbeyer matthiasbeyer marked this pull request as ready for review Oct 13, 2020
@lblasc
Copy link
Contributor

@lblasc lblasc commented Oct 14, 2020

Looks good. It would be great to merge it together with #93590

@matthiasbeyer
Copy link
Contributor Author

@matthiasbeyer matthiasbeyer commented Oct 25, 2020

Can this be merged?

@peti peti merged commit 40bc6c8 into NixOS:master Oct 25, 2020
19 of 20 checks passed
@matthiasbeyer matthiasbeyer deleted the update-r branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants