Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ham: 2019-01-22 -> 2020-09-09 #100399

Merged
merged 1 commit into from Oct 13, 2020
Merged

Conversation

@herrwiese
Copy link
Contributor

@herrwiese herrwiese commented Oct 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@stigtsp stigtsp left a comment

LGTM

  • Did very basic exec test of bin/ham
  • Matches latest commit from upstream

Result of nixpkgs-review pr 100399 1

2 packages built:
  • ham (perl532Packages.ham)
  • perl530Packages.ham

@stigtsp stigtsp merged commit ff69f8b into NixOS:master Oct 13, 2020
19 checks passed
@herrwiese herrwiese deleted the for-master/ham-2020-09-09 branch Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants