Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joplin-desktop: 1.1.4 -> 1.2.6 #100400

merged 1 commit into from Oct 13, 2020

joplin-desktop: 1.1.4 -> 1.2.6 #100400

merged 1 commit into from Oct 13, 2020


Copy link

@JesusMtnez JesusMtnez commented Oct 13, 2020

Motivation for this change

Bump joplin-desktop to 1.2.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@JesusMtnez JesusMtnez changed the title joplin: 1.1.4 -> 1.2.6 joplin-desktop: 1.1.4 -> 1.2.6 Oct 13, 2020
@ofborg ofborg bot requested a review from HugoReeves Oct 13, 2020
ajs124 approved these changes Oct 13, 2020
Copy link

@HugoReeves HugoReeves left a comment

I am unable to build and test on NixOS right now but these changes seem fine and unlikely to break anything provided the ofborg tests pass.

@ajs124 ajs124 merged commit a1466db into NixOS:master Oct 13, 2020
19 checks passed
jfroche added a commit to jfroche/nixpkgs that referenced this issue Oct 13, 2020
@JesusMtnez JesusMtnez deleted the joplin branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants