Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtuner: init at 1.0 #100405

merged 1 commit into from Oct 14, 2020

xtuner: init at 1.0 #100405

merged 1 commit into from Oct 14, 2020


Copy link

@magnetophon magnetophon commented Oct 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@AndersonTorres AndersonTorres left a comment


meta = with stdenv.lib; {
homepage = "";
description = "Tuner for Jack Audio Connection Kit";
license = licenses.gpl2;
Copy link

@AndersonTorres AndersonTorres Oct 14, 2020

gpl2 is deprecated. According to the newest GNU guidelines, the projects need to be more explicit in this sense.

Please, verify if the upstream project uses "gpl2Only" (the license is not to be automatically upgraded) or "gpl2Plus" (the famous "or any posterior version"). You can search the source code or ask them directly.

[ Indeed they use the gpl2Plus version: ]

@AndersonTorres AndersonTorres merged commit 09ccd16 into NixOS:master Oct 14, 2020
19 checks passed
Copy link
Member Author

@magnetophon magnetophon commented Oct 14, 2020

@AndersonTorres Thanks!

@magnetophon magnetophon deleted the xtuner branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants