Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biber: add patch for upstream bug 329 #100423

Merged
merged 1 commit into from Oct 13, 2020
Merged

biber: add patch for upstream bug 329 #100423

merged 1 commit into from Oct 13, 2020

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Oct 13, 2020

Motivation for this change

Fixes issue reported by @gebner in #100121 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 13, 2020

Does it need backporting? Will it be solved next release?

@veprbl
Copy link
Member Author

@veprbl veprbl commented Oct 13, 2020

@AndersonTorres According to the original report, this is a bug only in biber 2.15. The 20.09 has texlive 2019 and biber 2.14.

@veprbl
Copy link
Member Author

@veprbl veprbl commented Oct 13, 2020

The patch is from an upstream commit, so I expect to not need the fix in biber 2.16, of course.

@gebner gebner merged commit 23afa2a into NixOS:master Oct 13, 2020
18 of 20 checks passed
@veprbl veprbl deleted the pr/biber_fix_329 branch Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants