Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starboard: 0.4.0 -> 0.5.0 #100426

Merged
merged 1 commit into from Oct 13, 2020
Merged

starboard: 0.4.0 -> 0.5.0 #100426

merged 1 commit into from Oct 13, 2020

Conversation

@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Oct 13, 2020

Motivation for this change

Bump starboard to 0.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 13, 2020

Wow, the guys are really fast!

@AndersonTorres AndersonTorres merged commit fcac18a into NixOS:master Oct 13, 2020
19 checks passed
@06kellyjac
Copy link
Contributor Author

@06kellyjac 06kellyjac commented Oct 13, 2020

Wow, the guys are really fast!

Hehe, this one was a couple days ago.
Trivy update was about 10 mins before we merged.

Also the PRs were open for a while too

@06kellyjac 06kellyjac deleted the starboard_0.5.0 branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants