Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ultralist: rename from todolist, update #100447

Merged
merged 2 commits into from Jan 13, 2021
Merged

Conversation

@uvNikita
Copy link
Contributor

@uvNikita uvNikita commented Oct 13, 2020

Motivation for this change

todolist package was renamed to ultralist.
Here is announcement: ultralist/ultralist#136.

Also updated package to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 13, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/336

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 100447 run on x86_64-linux 1

1 package built:
  • ultralist

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 100447 run on x86_64-darwin 1

1 package built:
  • ultralist

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 27, 2020

Result of nixpkgs-review pr 100447 run on x86_64-linux 1

1 package built:
  • ultralist

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 29, 2020

Result of nixpkgs-review pr 100447 run on x86_64-darwin 1

1 package built:
  • ultralist

@ofborg ofborg bot requested a review from kalbasit Dec 29, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 11, 2021

@uvNikita please fix the merge conflict.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

diff LGTM

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 13, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 100447 run on x86_64-darwin 1

1 package built:
  • ultralist

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 13, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 100447 run on x86_64-linux 1

1 package built:
  • ultralist

@SuperSandro2000 SuperSandro2000 merged commit f73fb53 into NixOS:master Jan 13, 2021
19 checks passed
@uvNikita uvNikita deleted the ultralist branch Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants