Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rep: init at 0.2.1 #100448

Merged
merged 1 commit into from Oct 14, 2020
Merged

rep: init at 0.2.1 #100448

merged 1 commit into from Oct 14, 2020

Conversation

@eraserhd
Copy link
Contributor

@eraserhd eraserhd commented Oct 13, 2020

Motivation for this change

New package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@eraserhd eraserhd changed the title rep: init at 0.2.0 rep: init at 0.2.1 Oct 14, 2020
@eraserhd
Copy link
Contributor Author

@eraserhd eraserhd commented Oct 14, 2020

All feedback is resolved.

sikmir
sikmir approved these changes Oct 14, 2020
Copy link
Member

@glittershark glittershark left a comment

Built and tested against an nrepl, LGTM

Copy link
Member

@AndersonTorres AndersonTorres left a comment

LGTM, LGTBorg

pkgs/development/tools/rep/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rep/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rep/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rep/default.nix Outdated Show resolved Hide resolved
@AndersonTorres AndersonTorres merged commit b19efcc into NixOS:master Oct 14, 2020
19 checks passed
@eraserhd eraserhd deleted the rep-0.2.0 branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants