Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restic: 0.9.6 -> 0.10.0 #100452

Merged
merged 1 commit into from Oct 20, 2020
Merged

restic: 0.9.6 -> 0.10.0 #100452

merged 1 commit into from Oct 20, 2020

Conversation

@bbigras
Copy link
Contributor

@bbigras bbigras commented Oct 13, 2020

based on #98419

Motivation for this change
Things done

I removed the fuse tests with a patch since they were failing, probably because of the sandbox (permission denied).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/2b3f8kanpsg80j430lby4mq226pc0ryp-restic-0.9.6 101.9M
/nix/store/0n82y3i34ypjj2i9csp3h0b1bqda7dn0-restic-0.10.0 104.5M

1 package built:
restic

pkgs/tools/backup/restic/default.nix Outdated Show resolved Hide resolved
@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 13, 2020

goPackagePath can be removed, it isn't needed with buildGoModule

Co-authored-by: Martin Polden <mpolden@mpolden.no>
Co-authored-by: zowoq <59103226+zowoq@users.noreply.github.com>
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Oct 13, 2020

@zowoq done, thanks. Yeah, removing the file is better than a patch since.

bachp
bachp approved these changes Oct 14, 2020
Copy link
Member

@bachp bachp left a comment

Resulting binary is working

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 20, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/250

@AndersonTorres AndersonTorres merged commit fb9a2e7 into NixOS:master Oct 20, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a0b194"; rev="5a0b1947edb103a6cc9b5e027bdc59129b569f36"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a0b194"; rev="5a0b1947edb103a6cc9b5e027bdc59129b569f36"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a0b194"; rev="5a0b1947edb103a6cc9b5e027bdc59129b569f36"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a0b194"; rev="5a0b1947edb103a6cc9b5e027bdc59129b569f36"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a0b194"; rev="5a0b1947edb103a6cc9b5e027bdc59129b569f36"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a0b194"; rev="5a0b1947edb103a6cc9b5e027bdc59129b569f36"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a0b194"; rev="5a0b1947edb103a6cc9b5e027bdc59129b569f36"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
restic, restic.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
restic, restic.passthru.tests on x86_64-linux Success
Details
@bbigras bbigras deleted the restic branch Oct 20, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Oct 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants