Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restic: 0.9.6 -> 0.10.0 #100452

Merged
merged 1 commit into from Oct 20, 2020
Merged

restic: 0.9.6 -> 0.10.0 #100452

merged 1 commit into from Oct 20, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Oct 13, 2020

based on #98419

Motivation for this change
Things done

I removed the fuse tests with a patch since they were failing, probably because of the sandbox (permission denied).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/2b3f8kanpsg80j430lby4mq226pc0ryp-restic-0.9.6 101.9M
/nix/store/0n82y3i34ypjj2i9csp3h0b1bqda7dn0-restic-0.10.0 104.5M

1 package built:
restic

@zowoq
Copy link
Contributor

zowoq commented Oct 13, 2020

goPackagePath can be removed, it isn't needed with buildGoModule

@ofborg ofborg bot requested review from mbrgm and kalbasit October 13, 2020 22:40
@bbigras @mpolden @zowoq
restic: 0.9.6 -> 0.10.0
5a0b194 
Co-authored-by: Martin Polden <mpolden@mpolden.no>
Co-authored-by: zowoq <59103226+zowoq@users.noreply.github.com>
@bbigras
Copy link
Contributor Author

bbigras commented Oct 13, 2020

@zowoq done, thanks. Yeah, removing the file is better than a patch since.

bachp
bachp approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resulting binary is working

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/250

@AndersonTorres AndersonTorres merged commit fb9a2e7 into NixOS:master Oct 20, 2020
@bbigras bbigras deleted the restic branch October 20, 2020 18:53
@bbigras
Copy link
Contributor Author

bbigras commented Oct 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq left review comments

@bachp bachp bachp approved these changes

@mbrgm mbrgm Awaiting requested review from mbrgm

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bbigras @zowoq @nixos-discourse @bachp @AndersonTorres