Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytop: remove #100453

Merged
merged 1 commit into from Oct 15, 2020
Merged

ytop: remove #100453

merged 1 commit into from Oct 15, 2020

Conversation

@berbiche
Copy link
Member

@berbiche berbiche commented Oct 13, 2020

Motivation for this change

The maintainer of both packages [0] [1] has archived them.
The replacement, bottom, is available in nixpkgs and has been packaged by me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@berbiche
Copy link
Member Author

@berbiche berbiche commented Oct 13, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 13, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 13, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

pkgs/tools/system/gotop/default.nix Outdated Show resolved Hide resolved
Upstream has archived the repository and recommends bottom
@berbiche berbiche force-pushed the deprecate-ytop-gotop branch from 19970ab to 258ebb5 Oct 14, 2020
@berbiche berbiche changed the title Remove ytop and gotop ytop: remove Oct 14, 2020
@berbiche berbiche requested a review from marsam Oct 14, 2020
marsam
marsam approved these changes Oct 15, 2020
@marsam marsam merged commit d497f8b into NixOS:master Oct 15, 2020
16 checks passed
16 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="258ebb5"; rev="258ebb540e43b614d4ff206b3d445de9de570ecf"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="258ebb5"; rev="258ebb540e43b614d4ff206b3d445de9de570ecf"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="258ebb5"; rev="258ebb540e43b614d4ff206b3d445de9de570ecf"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="258ebb5"; rev="258ebb540e43b614d4ff206b3d445de9de570ecf"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="258ebb5"; rev="258ebb540e43b614d4ff206b3d445de9de570ecf"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="258ebb5"; rev="258ebb540e43b614d4ff206b3d445de9de570ecf"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="258ebb5"; rev="258ebb540e43b614d4ff206b3d445de9de570ecf"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
evanjs added a commit to evanjs/nixos_cfg that referenced this issue Nov 9, 2020
ytop has been abandoned upstream, and is no longer available in nixpkgs
as of NixOS/nixpkgs@258ebb5 / NixOS/nixpkgs#100453

Try using bottom, instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants