Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python{2,3}Package.zope_filerepresentation: fix test #100454

merged 1 commit into from Oct 13, 2020


Copy link

@jfroche jfroche commented Oct 13, 2020

Fix test

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@jfroche jfroche requested review from FRidh and jonringer as code owners Oct 13, 2020
@jfroche jfroche force-pushed the fix/zope_filerepresentation-test branch from 6a08120 to c66f9aa Oct 13, 2020
Copy link

@jonringer jonringer left a comment


Result of nixpkgs-review pr 100454 1

3 packages built:
  • python27Packages.zope_filerepresentation
  • python37Packages.zope_filerepresentation
  • python38Packages.zope_filerepresentation

@jonringer jonringer merged commit 74d8752 into NixOS:master Oct 13, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants