Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: De-inline uses of lib.boolToString #100456

Merged
merged 1 commit into from Oct 24, 2020
Merged

Conversation

@maralorn
Copy link
Member

@maralorn maralorn commented Oct 14, 2020

This commit should not change eval results

nixpkgs-review rev HEAD said Nothing to be built.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This commit should not change eval results
@maralorn
Copy link
Member Author

@maralorn maralorn commented Oct 14, 2020

Result of nixpkgs-review pr 100456 1

@andir andir merged commit 250fb46 into NixOS:master Oct 24, 2020
16 checks passed
@maralorn maralorn deleted the boolToString branch Oct 24, 2020
kini added a commit to kini/nixpkgs that referenced this issue Oct 26, 2020
I think there was a silent (i.e. semantic) merge conflict between PR NixOS#101139 and
PR NixOS#100456.  This commit should fix the error, which manifests as follows:

  error: undefined variable 'boolToString' at /home/kkini/src/nixpkgs/lib/types.nix:552:42
@kini kini mentioned this pull request Oct 26, 2020
10 tasks
SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this issue Oct 26, 2020
I think there was a silent (i.e. semantic) merge conflict between PR NixOS#101139 and
PR NixOS#100456.  This commit should fix the error, which manifests as follows:

  error: undefined variable 'boolToString' at /home/kkini/src/nixpkgs/lib/types.nix:552:42
SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this issue Oct 26, 2020
I think there was a silent (i.e. semantic) merge conflict between PR NixOS#101139 and
PR NixOS#100456.  This commit should fix the error, which manifests as follows:

  error: undefined variable 'boolToString' at /home/kkini/src/nixpkgs/lib/types.nix:552:42
SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this issue Oct 26, 2020
I think there was a silent (i.e. semantic) merge conflict between PR NixOS#101139 and
PR NixOS#100456.  This commit should fix the error, which manifests as follows:

  error: undefined variable 'boolToString' at /home/kkini/src/nixpkgs/lib/types.nix:552:42
blaggacao added a commit to xoe-labs/nixpkgs that referenced this issue Oct 27, 2020
I think there was a silent (i.e. semantic) merge conflict between PR NixOS#101139 and
PR NixOS#100456.  This commit should fix the error, which manifests as follows:

  error: undefined variable 'boolToString' at /home/kkini/src/nixpkgs/lib/types.nix:552:42
takagiy added a commit to takagiy/nixpkgs that referenced this issue Oct 30, 2020
I think there was a silent (i.e. semantic) merge conflict between PR NixOS#101139 and
PR NixOS#100456.  This commit should fix the error, which manifests as follows:

  error: undefined variable 'boolToString' at /home/kkini/src/nixpkgs/lib/types.nix:552:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants