Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions: update 10 #100465

Merged
merged 2 commits into from Oct 14, 2020
Merged

vscode-extensions: update 10 #100465

merged 2 commits into from Oct 14, 2020

Conversation

@eadwu
Copy link
Member

@eadwu eadwu commented Oct 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@eadwu eadwu requested a review from jonringer as a code owner Oct 14, 2020
@buckley310
Copy link
Contributor

@buckley310 buckley310 commented Oct 14, 2020

Tested the Python extension.
Opened a couple scripts in vscodium. Tried linting, auto-formatting, and goto-definition.
Looks good.

@garbas garbas merged commit fb6a662 into NixOS:master Oct 14, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants