Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: Fix pear path #100473

Merged
merged 1 commit into from Oct 14, 2020
Merged

php: Fix pear path #100473

merged 1 commit into from Oct 14, 2020

Conversation

@etu
Copy link
Contributor

@etu etu commented Oct 14, 2020

Motivation for this change

The out variable we had was both wrong since out should be without parens, but even with parens removed it was broken because it got quoted before sent to the configure script.

In 20.03 we never specified the path. So I just went back to not specifying the path.

Tested by building php74.unwrapped and php73.unwrapped and running:

./result/bin/php -r 'assert (@include_once "PEAR.php") && print("OK\n");'

on each version.

This fixes #100440

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@buckley310
Copy link
Contributor

@buckley310 buckley310 commented Oct 14, 2020

Looks good to me.
I have a pear-dependant webapp that breaks on 20.09 without this patch, but works with it applied.

@etu etu merged commit 89a166e into NixOS:master Oct 14, 2020
19 of 20 checks passed
@etu etu deleted the php-fix-pear branch Oct 14, 2020
@etu etu mentioned this pull request Oct 14, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants