Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli11: fix license and platforms #100478

Merged
merged 1 commit into from Dec 13, 2020
Merged

cli11: fix license and platforms #100478

merged 1 commit into from Dec 13, 2020

Conversation

@thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Oct 14, 2020

Motivation for this change

This builds and tests ok for me on aarch64-linux and x86_64-darwin, so I'm optimistically setting platforms to platforms.unix.

The license section in the readme says:

As of version 1.0, this library is available under a 3-Clause BSD license. See the LICENSE file for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@siraben
Copy link
Member

@siraben siraben commented Nov 22, 2020

Result of nixpkgs-review pr 100478 1

1 package built:
  • cli11

@marsam marsam merged commit 418d56e into NixOS:master Dec 13, 2020
19 checks passed
@thefloweringash thefloweringash deleted the cli11-meta branch Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants