Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riak-cs: delete #100495

Merged
merged 1 commit into from Nov 3, 2020
Merged

riak-cs: delete #100495

merged 1 commit into from Nov 3, 2020

Conversation

@DianaOlympos
Copy link
Contributor

@DianaOlympos DianaOlympos commented Oct 14, 2020

Motivation for this change

Now that Riak can run on modern version of OTP, it is time to drop what stopped being supported when Basho died. Riak-CS has had no new commit in 5 years. Time to drop it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@DianaOlympos DianaOlympos force-pushed the DianaOlympos:riak-cs-delete branch from 970966d to 916d930 Oct 15, 2020
@DianaOlympos
Copy link
Contributor Author

@DianaOlympos DianaOlympos commented Oct 15, 2020

Moved the throw to pkgs/top-level/aliases.nix

@DianaOlympos DianaOlympos force-pushed the DianaOlympos:riak-cs-delete branch from 916d930 to dd10173 Oct 28, 2020
@DianaOlympos
Copy link
Contributor Author

@DianaOlympos DianaOlympos commented Oct 28, 2020

@berbiche I rebased on master, could you re-review now with the changes so we can get that to master, so i can move to getting rid of riak and otp r16 ?

Copy link
Member

@berbiche berbiche left a comment

Removing the module options would need an entry in nixos/doc/manual/release-notes/rl-2103.xml under "Backward incompatibilities" in the form of

<listitem>
    <para>
    <package>riak-cs</package> package removed along with <varname>services.riak-cs</varname> module.
    </para>
</listitem>
<listitem>
    <para>
    <package>stanchion</package> package removed along with <varname>services.stanchion</varname> module.
    </para>
</listitem>
@DianaOlympos DianaOlympos force-pushed the DianaOlympos:riak-cs-delete branch from dd10173 to 63caece Oct 28, 2020
@DianaOlympos
Copy link
Contributor Author

@DianaOlympos DianaOlympos commented Oct 28, 2020

Well i did add it and deleted it today welp :D ok done

@berbiche
Copy link
Member

@berbiche berbiche commented Oct 28, 2020

I am not part of the org, so someone else will have to merge this.

Good case for https://github.com/apps/marvin-mk2

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/274

@kevincox kevincox merged commit 8230e62 into NixOS:master Nov 3, 2020
17 checks passed
17 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63caece"; rev="63caecee7d9a77ae9a645d269bca06981f7666bf"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63caece"; rev="63caecee7d9a77ae9a645d269bca06981f7666bf"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63caece"; rev="63caecee7d9a77ae9a645d269bca06981f7666bf"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63caece"; rev="63caecee7d9a77ae9a645d269bca06981f7666bf"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63caece"; rev="63caecee7d9a77ae9a645d269bca06981f7666bf"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63caece"; rev="63caecee7d9a77ae9a645d269bca06981f7666bf"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="63caece"; rev="63caecee7d9a77ae9a645d269bca06981f7666bf"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants