Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.tasklib: 2.2.0 -> 2.2.1 #100497

Closed

Conversation

@Chickensoupwithrice
Copy link

@Chickensoupwithrice Chickensoupwithrice commented Oct 14, 2020

Motivation for this change

Update tasklib to 2.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Please remove the already merged commit from this PR.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100497 run on x86_64-linux 1

1 package failed to build:
  • python27Packages.tasklib
3 packages built:
  • python37Packages.tasklib
  • python38Packages.tasklib
  • vit

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

builder for '/nix/store/hwamy5r4ilgd9nkl2zm42wa38cqx8qm1-python2.7-tasklib-2.2.1.drv' failed with exit code 1; last 10 log lines:                                                                 self.module)                                                                                                                                                                              File "/nix/store/vfd4wghhzz4afzxgwynsnbj9xzpkib4z-python-2.7.18/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
      suites = [self.loadTestsFromName(name, module) for name in names]
    File "/nix/store/vfd4wghhzz4afzxgwynsnbj9xzpkib4z-python-2.7.18/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName
      module = __import__('.'.join(parts_copy))
    File "/build/tasklib-2.2.1/tasklib/__init__.py", line 1, in <module>
      from .backends import TaskWarrior
    File "/build/tasklib-2.2.1/tasklib/backends.py", line 9, in <module>
      from functools import lru_cache
  ImportError: cannot import name lru_cache
cannot build derivation '/nix/store/piayl5bl8x7xp4qpzqz513dmgqn3v7jj-env.drv': 1 dependencies couldn't be built

Probably needs to be marked python3 only.

@fabaff
Copy link
Member

@fabaff fabaff commented Feb 13, 2021

Was superseded by #108368.

@fabaff fabaff closed this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants