Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyatv: move pytestCheckHook to checkInputs #100499

Merged
merged 1 commit into from Oct 19, 2020

Conversation

@uvNikita
Copy link
Contributor

@uvNikita uvNikita commented Oct 14, 2020

Motivation for this change

backport of #100489

ZHF: #97479

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

}:

buildPythonPackage rec {
pname = "pyatv";
version = "0.7.2";
version = "v0.7.4";
Copy link
Contributor

@jonringer jonringer Oct 16, 2020

v prefix is a version control convention to distinguish between branches and releases, it should be left off

Suggested change
version = "v0.7.4";
version = "0.7.4";

src = fetchFromGitHub {
owner = "postlund";
repo = pname;
rev = version;
Copy link
Contributor

@jonringer jonringer Oct 16, 2020

Suggested change
rev = version;
rev = "v${version}";

@@ -31,6 +36,8 @@ buildPythonPackage rec {
protobuf
cryptography
netifaces
zeroconf
pytestCheckHook
Copy link
Contributor

@jonringer jonringer Oct 16, 2020

Suggested change
pytestCheckHook
pytestCheckHook

this should be in checkInputs

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 16, 2020

Please rebase onto master, then we can cherry-pick it onto release

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100499 1

2 packages built:
  • python37Packages.pyatv
  • python38Packages.pyatv

@jonringer jonringer merged commit d7f7eb2 into NixOS:master Oct 19, 2020
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment