Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bup: use python3 #100503

Merged
merged 1 commit into from Oct 22, 2020
Merged

bup: use python3 #100503

merged 1 commit into from Oct 22, 2020

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 14, 2020

Motivation for this change

The neverending quest for the deprecation of python 2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via make long-check: everything passes except two tests about man (probably unrelated)
  • Tested compilation of all pkgs that depend on this change (bup)
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @muflax

@samuela
Copy link
Member

@samuela samuela commented Oct 16, 2020

I'm getting some nixpkgs-review errors:

> nixpkgs-review pr 100503
/nix/store/2jysm3dfsgby5sw5jgj43qjrb5v79ms9-bash-4.4-p23/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/100503/head:refs/nixpkgs-review/1
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Total 7 (delta 5), reused 5 (delta 5), pack-reused 2
Unpacking objects: 100% (7/7), 707 bytes | 117.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   a4d05ec30c6..dfd0a64c1a2  master                -> refs/nixpkgs-review/0
 + 22659aea275...23f735224c5 refs/pull/100503/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/skainswo/.cache/nixpkgs-review/pr-100503/nixpkgs dfd0a64c1a25150092e1e6200fdc59da309466e5
Preparing worktree (detached HEAD dfd0a64c1a2)
Updating files: 100% (22950/22950), done.
HEAD is now at dfd0a64c1a2 Merge pull request #100656 from r-ryantm/auto-update/python3.7-entrypoint2
$ git merge --no-commit 23f735224c53bb69e79c1c98e55651b4f140f5b1
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/skainswo/.cache/nixpkgs-review/pr-100503/build.nix
builder for '/nix/store/9ji8za4j7xvi0jkcmi3swsq76lqnp7sb-python3.7-git-annex-adapter-0.2.2.drv' failed with exit code 1; last 10 log lines:
  AssertionError: '{"co[39 chars]rue,"input":["{\\"key\\":\\"SHA256E-s0--0\\"}"[44 chars]:{}}' != '{"co[39 chars]rue,"key":"SHA256E-s0--0","file":null,"fields":{}}'
  - {"command":"metadata","note":"","success":true,"input":["{\"key\":\"SHA256E-s0--0\"}"],"key":"SHA256E-s0--0","file":null,"fields":{}}
  ?                                                 ----------------------------------------
  + {"command":"metadata","note":"","success":true,"key":"SHA256E-s0--0","file":null,"fields":{}}
  
  
  ----------------------------------------------------------------------
  Ran 27 tests in 5.393s
  
  FAILED (failures=5, skipped=1)
builder for '/nix/store/kp1g8j1hnnb31w8dimkzsrg9xiw361ig-python3.8-git-annex-adapter-0.2.2.drv' failed with exit code 1; last 10 log lines:
  AssertionError: '{"co[39 chars]rue,"input":["{\\"key\\":\\"SHA256E-s0--0\\"}"[44 chars]:{}}' != '{"co[39 chars]rue,"key":"SHA256E-s0--0","file":null,"fields":{}}'
  - {"command":"metadata","note":"","success":true,"input":["{\"key\":\"SHA256E-s0--0\"}"],"key":"SHA256E-s0--0","file":null,"fields":{}}
  ?                                                 ----------------------------------------
  + {"command":"metadata","note":"","success":true,"key":"SHA256E-s0--0","file":null,"fields":{}}
  
  
  ----------------------------------------------------------------------
  Ran 27 tests in 5.455s
  
  FAILED (failures=5, skipped=1)
cannot build derivation '/nix/store/66yvccyz7462cssgvmr1zwq9189d7sy2-git-annex-metadata-gui-0.2.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/38p9d6ipsm26q8j8dxkryy16q4r1j3c9-env.drv': 3 dependencies couldn't be built
[6 built (2 failed), 797 copied (5639.2 MiB), 630.6 MiB DL]
error: build of '/nix/store/38p9d6ipsm26q8j8dxkryy16q4r1j3c9-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/100503
3 packages failed to build:
gitAndTools.git-annex-metadata-gui python37Packages.git-annex-adapter python38Packages.git-annex-adapter

2 packages built:
bup gitAndTools.gitAnnex

[0.0 MiB DL]
error: build log of '/nix/store/66yvccyz7462cssgvmr1zwq9189d7sy2-git-annex-metadata-gui-0.2.0.drv' is not available
$ nix-shell /home/skainswo/.cache/nixpkgs-review/pr-100503/shell.nix
these paths will be fetched (0.51 MiB download, 2.47 MiB unpacked):
  /nix/store/82bsy6f0bz7avmy8y62j0z2dnxgi8pxw-bash-interactive-4.4-p23-doc
  /nix/store/b6mp5xw5pjr3bsmk3fphkyxw73vc806j-bash-interactive-4.4-p23-info
  /nix/store/hfvjs6abgzadrv9f387v1ip5mr206jh9-bash-interactive-4.4-p23-dev
  /nix/store/xpmrr7kyzlbny0540kzd1vlqsca69y13-bash-interactive-4.4-p23-man
copying path '/nix/store/82bsy6f0bz7avmy8y62j0z2dnxgi8pxw-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/hfvjs6abgzadrv9f387v1ip5mr206jh9-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/b6mp5xw5pjr3bsmk3fphkyxw73vc806j-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/xpmrr7kyzlbny0540kzd1vlqsca69y13-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...

@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Oct 16, 2020

Ah, it looks like git-annex depends on bup, I had no idea. The failures are in some other package which depends on git-annex but I don't think have anything to do with bup. I'm more worried about the failure on aarch64.

@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Oct 16, 2020

aarch64 is failing due to pandoc, which is unrelated too.

@rnhmjoj rnhmjoj merged commit c5c468b into NixOS:master Oct 22, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
bup, bup.passthru.tests on x86_64-darwin
Details
@ofborg
bup, bup.passthru.tests on aarch64-linux Failure
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
bup, bup.passthru.tests on x86_64-linux Success
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="23f7352"; rev="23f735224c53bb69e79c1c98e55651b4f140f5b1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="23f7352"; rev="23f735224c53bb69e79c1c98e55651b4f140f5b1"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="23f7352"; rev="23f735224c53bb69e79c1c98e55651b4f140f5b1"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="23f7352"; rev="23f735224c53bb69e79c1c98e55651b4f140f5b1"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="23f7352"; rev="23f735224c53bb69e79c1c98e55651b4f140f5b1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="23f7352"; rev="23f735224c53bb69e79c1c98e55651b4f140f5b1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="23f7352"; rev="23f735224c53bb69e79c1c98e55651b4f140f5b1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants